shunping commented on code in PR #37379:
URL: https://github.com/apache/beam/pull/37379#discussion_r2737921919
##########
sdks/python/container/boot.go:
##########
@@ -220,7 +220,18 @@ func launchSDKProcess() error {
// (3) Invoke python
- os.Setenv("PIPELINE_OPTIONS", options)
+ //Commented out -->
+ //os.Setenv("PIPELINE_OPTIONS", options)
+
+ //To prevent crashes if options > ARG_MAX -->
+ // --> Write the large JSON content into a file on disk
+ // --> environment only receives the short filename
+ if optionsFile, err := MakePipelineOptionsFileAndEnvVar(options); err
!= nil {
+ logger.Fatalf(ctx, "Failed to create a pipeline options file:
%v", err)
Review Comment:
For consistency, could we use the same error message as Java and GO Sdks?
https://github.com/apache/beam/blob/928ad7e2aab52ce5bd36895bae1d17bd9d8d5124/sdks/go/container/boot.go#L198-L199
https://github.com/apache/beam/blob/928ad7e2aab52ce5bd36895bae1d17bd9d8d5124/sdks/java/container/boot.go#L126-L127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
