claudevdm commented on code in PR #37434:
URL: https://github.com/apache/beam/pull/37434#discussion_r2743863063
##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -1834,6 +1834,17 @@ def with_outputs(self, *tags, main=None,
allow_unknown_tags=None):
raise ValueError(
'Main output tag %r must be different from side output tags %r.' %
(main, tags))
+ type_hints = self.get_type_hints()
+ declared_tags = set(type_hints.tagged_output_types().keys())
+ requested_tags = set(tags)
+
+ unknown = requested_tags - declared_tags
+ if unknown and declared_tags: # Only warn if type hints exist
+ logging.warning(
+ "Tags %s requested in with_outputs() but not declared "
Review Comment:
pylint: Use lazy % or % formatting in logging functions
(logging-fstring-interpolation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
