robertwb commented on PR #37434: URL: https://github.com/apache/beam/pull/37434#issuecomment-3826551998
> > Very nice. > > Have you looked into updating type inference to be able to handle TaggedOutput types? > > What do you mean by this? Are you referring to > > https://github.com/apache/beam/blob/96edda499eaa942815a952b3aaa76b69b83ad753/sdks/python/apache_beam/pipeline.py#L995 > > This already works and I should remove the TODO comment. The element type will already be set in DoOutputsTuple when the tagged pcollection is created. > > Very nice. > > Have you looked into updating type inference to be able to handle TaggedOutput types? > > What do you mean by this? Are you referring to > > https://github.com/apache/beam/blob/96edda499eaa942815a952b3aaa76b69b83ad753/sdks/python/apache_beam/pipeline.py#L995 > > This already works and I should remove the TODO comment. The element type will already be set in DoOutputsTuple when the tagged pcollection is created. I was thinking something like test_pardo_annotation_process_method would work even if the user didn't add type hints to the function manually. (This could be a follow-up PR, as it might actually impact more live code out there.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
