PDGGK commented on PR #37530:
URL: https://github.com/apache/beam/pull/37530#issuecomment-3863753266
Thanks for the review! I've addressed both comments:
1. **Removed catch-all block**: No longer needed - using defensive
TypeDescriptor API calls
2. **Using TypeDescriptor methods throughout**:
- `resolveType()` to extract ValueState's type parameter
- `hasUnresolvedParameters()` instead of instanceof checks
- `isSubtypeOf()` for collection type detection
This keeps all logic within the TypeDescriptor API as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
