gemini-code-assist[bot] commented on PR #37586: URL: https://github.com/apache/beam/pull/37586#issuecomment-3893486883
## Summary of Changes Hello @mutianf, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces an experimental feature for the Apache Beam Bigtable I/O connector, allowing users to configure the Bigtable client to skip excessively large rows during read operations. This enhancement aims to improve the robustness and efficiency of pipelines by preventing failures or performance degradation caused by individual rows that exceed typical processing capacities, offering a graceful way to handle such data anomalies. ### Highlights * **New Experimental Option**: Introduced a new experimental option, `bigtable_enable_skip_large_rows`, to control the behavior of skipping large rows during Bigtable reads. * **Bigtable Service Integration**: Modified `BigtableServiceFactory` to detect the `bigtable_enable_skip_large_rows` experiment and pass this configuration to the `BigtableServiceImpl`. * **Conditional Row Skipping Logic**: Updated `BigtableServiceImpl` to include a `skipLargeRows` flag, which, when enabled, instructs the Bigtable client to use a specialized `skipLargeRowsCallable` for reading, effectively ignoring rows exceeding a certain size. * **Integration Test for Skipping Large Rows**: Added an end-to-end integration test in `BigtableReadIT` to validate that when the `bigtable_enable_skip_large_rows` experiment is active, large rows are indeed skipped during Bigtable read operations. * **Unit Test Adaptation**: Adjusted `BigtableServiceImplTest` to accommodate the new constructor parameter for `BigtableServiceImpl.BigtableReaderImpl`, ensuring existing tests remain functional. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceFactory.java** * Added a new constant `BIGTABLE_ENABLE_SKIP_LARGE_ROWS`. * Modified `getServiceForReading` to check for the new experimental option and pass it to the `BigtableServiceImpl` constructor. * **sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java** * Added a `skipLargeRows` field and a new constructor to `BigtableServiceImpl`. * Updated the existing `BigtableServiceImpl` constructor to delegate to the new one with `skipLargeRows` set to `false`. * Modified `BigtableReaderImpl` to store the `skipLargeRows` flag. * Updated `BigtableReaderImpl.start()` to conditionally use `client.skipLargeRowsCallable()` or `client.readRowsCallable()` based on the `skipLargeRows` flag. * **sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadIT.java** * Added new imports for Bigtable client and Beam SDK components. * Implemented `testE2EBigtableReadWithSkippingLargeRows` to verify the large row skipping functionality. * **sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImplTest.java** * Updated the `BigtableReaderImpl` constructor call in `testRead` to include the new `skipLargeRows` parameter, set to `false`. </details> <details> <summary><b>Activity</b></summary> * No human activity (comments, reviews) has been recorded for this pull request yet. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
