Abacn commented on code in PR #37586:
URL: https://github.com/apache/beam/pull/37586#discussion_r2805074506
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceFactory.java:
##########
@@ -133,7 +135,10 @@ BigtableServiceEntry getServiceForReading(
BigtableDataSettings.enableBuiltinMetrics();
}
- BigtableService service = new BigtableServiceImpl(settings);
+ boolean skipLargeRows =
+ ExperimentalOptions.hasExperiment(pipelineOptions,
BIGTABLE_ENABLE_SKIP_LARGE_ROWS);
Review Comment:
What's the consideration using an experiment to plumbing this config here?
In general undocumented pipeline experiments are discouraged. It sounds
something should live in BigtableReadOptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
