Abacn commented on code in PR #37611:
URL: https://github.com/apache/beam/pull/37611#discussion_r2817710685
##########
sdks/java/io/clickhouse/src/main/java/org/apache/beam/sdk/io/clickhouse/ClickHouseIO.java:
##########
@@ -63,15 +62,27 @@
*
* <h3>Writing to ClickHouse</h3>
*
- * <p>To write to ClickHouse, use {@link ClickHouseIO#write(String, String)},
which writes elements
- * from input {@link PCollection}. It's required that your ClickHouse cluster
already has table you
- * are going to insert into.
+ * <p>To write to ClickHouse, use {@link ClickHouseIO#write(String, String,
String)}, which writes
+ * elements from input {@link PCollection}. It's required that your ClickHouse
cluster already has
+ * table you are going to insert into.
*
* <pre>{@code
+ * // New way (recommended):
Review Comment:
Since the upgrade changed recommended API surfaces, could you please add an
item in
https://github.com/apache/beam/blob/master/CHANGES.md
noting client upgrade and a link to here for migration guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
