chamikaramj commented on code in PR #37611:
URL: https://github.com/apache/beam/pull/37611#discussion_r2818528511
##########
sdks/java/io/clickhouse/src/main/java/org/apache/beam/sdk/io/clickhouse/ClickHouseIO.java:
##########
@@ -431,25 +552,46 @@ private void flush() throws Exception {
}
batchSize.update(buffer.size());
+
+ // Serialize rows to RowBinary format
+ ByteArrayOutputStream byteStream = new ByteArrayOutputStream();
+
+ // Wrap ByteArrayOutputStream with ClickHouseOutputStream
+ try (com.clickhouse.data.ClickHouseOutputStream outputStream =
+ com.clickhouse.data.ClickHouseOutputStream.of(byteStream)) {
+ for (Row row : buffer) {
+ ClickHouseWriter.writeRow(outputStream, schema(), row);
Review Comment:
Sg, handling for replicated table engines and documentation regarding
possible duplicate data should be adequate I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
