gemini-code-assist[bot] commented on PR #37631:
URL: https://github.com/apache/beam/pull/37631#issuecomment-3917607144
## Summary of Changes
Hello @acrites, I'm Gemini Code Assist[^1]! I'm currently reviewing this
pull request and will post my feedback shortly. In the meantime, here's a
summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the Apache Beam Java SDK's ability
to handle `SchemaCoders` in a portable and forward-compatible manner. By
introducing a dedicated `CoderTranslator` for `SchemaCoder`, the system can now
separate the schema definition from the `toRowFn` and `fromRowFn` logic, which
allows runners to better understand and adapt to schema changes during pipeline
updates. A crucial aspect of this change is the inclusion of `PipelineOptions`
in the translation context, providing a mechanism to maintain backward
compatibility for older pipelines by reverting to the previous custom Java
coder translation when a specific compatibility version is set.
### Highlights
* **Portable SchemaCoder Translation**: Introduced a new portable
`CoderTranslator` for Java `SchemaCoder` to improve runner compatibility and
enable schema evolution by splitting the Schema proto from `toRowFn` and
`fromRowFn`.
* **Backward Compatibility**: Integrated `PipelineOptions` into
`CoderTranslator` contexts, allowing for backward-compatible `SchemaCoder`
translation. Old-style translation can be preserved for compatibility versions
less than '2.72' (e.g., by setting
`StreamingOptions.setUpdateCompatibilityVersion("2.71")`).
* **Issue Resolution**: Resolved several existing issues related to Schema
handling and pipeline updates, specifically addressing #36496, #30276, and
#29245.
🧠**New Feature in Public Preview:** You can now enable **Memory** to help
**Gemini Code Assist** learn from your team's feedback. This makes future code
reviews more consistent and personalized to your project's style. **Click
[here](https://codeassist.google/code-review/login) to enable Memory in your
admin console.**
<details>
<summary><b>Changelog</b></summary>
* **CHANGES.md**
* Updated breaking changes section to document portable SchemaCoder
encoding, compatibility options, and fixed issues.
*
**runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java**
* Modified `SdkComponents.create` calls to include `PipelineOptions` for
context.
*
**runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java**
* Updated `SdkComponents.create` calls to pass `PipelineOptions` and
refined a comment regarding job submission types.
*
**runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java**
* Added necessary imports for `AutoValue` and schema-related classes.
* Updated `createSdkComponents` to use `PipelineOptions`.
* Introduced a new test case for `SchemaCoder` translation with
compatibility checks.
*
**sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/CoderTranslation.java**
* Modified the `toKnownCoder` method to pass `PipelineOptions` via a new
`TranslationContextWithOptions` to `CoderTranslator` methods.
*
**sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/CoderTranslator.java**
* Updated `getUrn` and `getPayload` methods to accept a
`TranslationContext`.
* Provided a default `getUrn` implementation.
*
**sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/CoderTranslators.java**
* Defined `TranslationContextWithOptions` to expose `PipelineOptions`.
* Updated `getPayload` signatures for `ParamWindowedValueCoder` and
`RowCoder` to accept `TranslationContext`.
* Implemented a new `schema()` translator for `SchemaCoder` that handles
portable encoding and backward compatibility.
*
**sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/ModelCoderRegistrar.java**
* Registered the new `SchemaCoder` and its corresponding translator.
*
**sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/ModelCoders.java**
* Defined a new URN constant for `SchemaCoder`.
*
**sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/RehydratedComponents.java**
* Modified `getSdkComponents` to include `PipelineOptions` when creating
`SdkComponents`.
*
**sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/SdkComponents.java**
* Added a `PipelineOptions` field.
* Updated constructors and `create` methods to manage these options.
* Exposed a `getPipelineOptions` method.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/CoderTranslationTest.java**
* Added a test `AutoValue` class, `SchemaRegistry` setup, and a helper
for `SchemaCoder` creation.
* Included `SchemaCoder` in the set of known coders for testing.
*
**sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java**
* Corrected a typo in a log message.
* Added a clarifying comment about `SdkComponents` and `PipelineOptions`.
*
**sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/AvroGenericCoderTranslator.java**
* Updated the `getPayload` method signature to accept a
`TranslationContext`.
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation
page](https://developers.google.com/gemini-code-assist/docs/review-github-code),
here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment
using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a
summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull
request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current
pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged,
both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository
maintainers can create a configuration file and/or provide a custom code review
style guide (such as PEP-8 for Python) by creating and adding files to a
`.gemini/` folder in the base of the repository. Detailed instructions can be
found
[here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances
where its feedback is incorrect or counter productive. You can react with
:thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're
interested in giving your feedback about your experience with Gemini Code
Assist for Github and other Google products, sign up
[here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code
reviews directly in the IDE at no cost with the [Gemini Code Assist IDE
Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy),
[Generative AI Prohibited Use
Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of
Service](https://policies.google.com/terms), and learn how to configure Gemini
Code Assist in GitHub
[here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
Gemini can make mistakes, so double check it and [use code with
caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
