acrites commented on code in PR #37631:
URL: https://github.com/apache/beam/pull/37631#discussion_r2830709276


##########
sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java:
##########
@@ -675,6 +675,8 @@ private Map<String, TransformProvider> 
loadRegisteredTransforms() {
             inputs);
 
     // Needed to find which transform was new...
+    // This SdkComponents comes from rehydratedComponents, but doesn't take 
into account any
+    // additional translation options specified in PipelineOptions.

Review Comment:
   I actually think it *will* use pipeline options because the 
rehydratedComponents object is constructed using `withPipeline()`, which copies 
over the pipeline options.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to