shunping commented on code in PR #37674:
URL: https://github.com/apache/beam/pull/37674#discussion_r2836201380
##########
sdks/python/apache_beam/io/gcp/gcsfilesystem_test.py:
##########
@@ -48,6 +48,13 @@ def test_scheme(self):
self.assertEqual(self.fs.scheme(), 'gs')
self.assertEqual(gcsfilesystem.GCSFileSystem.scheme(), 'gs')
+ def test_get_filesystem_does_not_require_gcp_extra(self):
Review Comment:
If this test is run in a Python environment with gcp extra, this test will
always pass.
To really test it, I think we need to mock the behavior of not having gcp
extra (i.e not being able to import gcsio) and ensure getFileSystem can run
without it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
