MansiSingh17 commented on PR #37674:
URL: https://github.com/apache/beam/pull/37674#issuecomment-3939768917
Hi @shunping , I've addressed all three review comments:
1. Updated test_get_filesystem_does_not_require_gcp_extra to use
@mock.patch('apache_beam.io.gcp.gcsfilesystem.gcsio', None) to properly
simulate missing GCP extra regardless of environment
2. Simplified _gcsIO() to use module-level gcsio directly — no re-importing
3. Same for report_lineage — using module-level gcsio directly now
The test_lineage failure is a local env issue (missing google.api_core) — it
was skipped on master before this PR and should pass in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
