shunping commented on PR #37488: URL: https://github.com/apache/beam/pull/37488#issuecomment-3947262117
@MansiSingh17 and @RushabhRatnaparkhi: I see good things in both of your PR #37674 and #37488, but I also think they both need some more polishing. - On one hand, #37674 introduced a new `_get_gcsio()` and changed the mocking in the tests, which I think it is clumsy and not necessary. - On the other hand, #37488 had some test failure. It would be great if we can merge the two solutions together. Could you two collaborate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
