acrites commented on code in PR #37723:
URL: https://github.com/apache/beam/pull/37723#discussion_r2874270805
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/processing/StreamingWorkScheduler.java:
##########
@@ -246,6 +246,7 @@ private void processWork(ComputationState computationState,
Work work) {
// Before any processing starts, call any pending OnCommit callbacks.
Nothing that requires
// cleanup should be done before this, since we might exit early here.
commitFinalizer.finalizeCommits(workItem.getSourceState().getFinalizeIdsList());
Review Comment:
Both ParDo and SourceState finalize ids are set in
`StreamingModeExecutionContext.flushState()` by calling
`ThreadLocalRandom.current().nextLong()` (from the same thread). So it should
be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
