acrites commented on code in PR #37723:
URL: https://github.com/apache/beam/pull/37723#discussion_r2885580926
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/SimpleParDoFnTest.java:
##########
@@ -716,41 +711,36 @@ public void afterBundleCommit(Instant expiry, Callback
callback) {
parDoFn.finishBundle();
- // The counter increases by 1 in StartBundle, 5 in ProcessElement, and 1
in FinishBundle.
- // Total should be 7.
- assertThat(getBundleSuccessCount(), equalTo(7));
+ assertThat(startBundleCount.get(), equalTo(1));
+ assertThat(processElementCount.get(), equalTo(5));
+ assertThat(finishBundleCount.get(), equalTo(1));
}
- private static final AtomicInteger bundleSuccessCount = new AtomicInteger(0);
-
- static void increaseBundleSuccessCount() {
- bundleSuccessCount.incrementAndGet();
- }
-
- static int getBundleSuccessCount() {
- return bundleSuccessCount.get();
- }
+ private static final AtomicInteger startBundleCount = new AtomicInteger(0);
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
