gemini-code-assist[bot] commented on code in PR #37715:
URL: https://github.com/apache/beam/pull/37715#discussion_r2856690981
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/OrFinallyTrigger.java:
##########
@@ -64,6 +64,12 @@ public boolean mayFinish() {
return subTriggers.get(ACTUAL).mayFinish() ||
subTriggers.get(UNTIL).mayFinish();
}
+ @Override
+ public boolean isCompatibleWithCombinerLifting() {
+ return subTriggers.get(ACTUAL).isCompatibleWithCombinerLifting()
+ && subTriggers.get(UNTIL).isCompatibleWithCombinerLifting();
+ }
Review Comment:
For consistency with other composite triggers, you could use a stream over
`subTriggers` here as well. This would make the code more uniform and align
with the pattern used in `AfterAll`, `AfterFirst`, and `AfterEach`.
```suggestion
@Override
public boolean isCompatibleWithCombinerLifting() {
return
subTriggers.stream().allMatch(Trigger::isCompatibleWithCombinerLifting);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
