kennknowles commented on code in PR #37715:
URL: https://github.com/apache/beam/pull/37715#discussion_r2885516488
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/TriggerVisitor.java:
##########
@@ -15,20 +15,33 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.beam.runners.dataflow.worker.windmill.state;
+package org.apache.beam.sdk.transforms.windowing;
-import com.google.auto.value.AutoValue;
-import org.apache.beam.runners.core.TimerInternals.TimerData;
-import org.apache.beam.runners.dataflow.worker.WindmillTimerType;
+/** A TriggerVisitor. */
+public interface TriggerVisitor<OutputT> {
Review Comment:
Since this doesn't do a recursive traversal, it is more like a `match` than
a `visit`, in the sense that it is up to the caller to remember and properly
process the recursive structure of each case. How about we mark it `@Internal`
(and also `accept(...)`) and call it good though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
