LEEKYE commented on code in PR #37691:
URL: https://github.com/apache/beam/pull/37691#discussion_r2885349795
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java:
##########
@@ -246,7 +246,9 @@ private void addRunnerAndConsumersForPTransformRecursively(
BundleFinalizer bundleFinalizer,
Collection<BeamFnDataReadRunner<?>> channelRoots,
Map<ApiServiceDescriptor, BeamFnDataOutboundAggregator>
outboundAggregatorMap,
- Set<String> runnerCapabilities)
+ Set<String> runnerCapabilities,
+ boolean hasNoState,
Review Comment:
At least from my cl in uw side, when it is batch, both fields will be set to
true, but I am not really sure if these two fields should have different values
in different scenarios. Since these 2 are both new fields that have no
occurrences anywhere else, I don't think they will have different values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
