acrites commented on code in PR #37691:
URL: https://github.com/apache/beam/pull/37691#discussion_r2933822499
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/FnApiStateAccessor.java:
##########
@@ -114,6 +114,8 @@ public static class Factory<K> {
private final Map<TupleTag<?>, SideInputSpec> sideInputSpecMap;
private final Coder<K> keyCoder;
private final Coder<BoundedWindow> windowCoder;
+ private final boolean hasNoState;
+ private final boolean onlyBundleForKeys;
Review Comment:
I still don't think these can be booleans, but rather need to be
`Supplier<boolean>`. For batch, it might be true that both values will be true
for all work items and all keys, but for streaming that's not the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
