dejii opened a new pull request, #37782:
URL: https://github.com/apache/beam/pull/37782
### Summary
- Remove FileIO field and close logic from `RecordWriter` - it no longer
owns the FileIO lifecycle
- Move FileIO cleanup to `RecordWriterManager.close()`, which collects
unique FileIO instances across all destinations and closes each once in a
finally block
- Add tests covering the fix
### Root Cause
- `table.io()` returns the catalog's shared `FileIO` instance. Catalogs like
`RESTSessionCatalog` track and reuse a single FileIO across tables via
`FileIOTracker` ([ref][1]). When `RecordWriter.close()` called `io.close()`, it
shut down the shared connection pool.
- This manifests when using dynamic destinations:
`RecordWriterManager.close()` iterates destinations and calls
`cache.invalidateAll()` on each, which triggers `RecordWriter.close()` via the
removal listener. The first destination's writers close successfully but kill
the shared pool - subsequent destinations fail with:
```
IllegalStateException: Encountered 12 failed writer(s).
Caused by: IOException: Failed to close PARQUET writer for table ...
Caused by: IOException: Connection pool shut down
Caused by: IllegalStateException: Connection pool shut down
Suppressed: RuntimeException: Encountered an error when closing data
writer for table ...
Suppressed: RuntimeException: ...
```
The fix moves FileIO close to `RecordWriterManager.close()`, which
deduplicates by identity and closes each shared instance exactly once after all
writers have flushed.
[1]:
https://github.com/apache/iceberg/blob/88d460425ab6a0e4c938e90665b4b772d7b57c41/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L1167
Related: #36438
I can confirm this works fix works great when running in Dataflow.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
