ahmedabu98 commented on PR #37782: URL: https://github.com/apache/beam/pull/37782#issuecomment-4011992731
Did some digging to verify some assumptions. It looks like the catalog creates a new TableOperations instance per table: [BaseMetastoreCatalog#L48](https://github.com/apache/iceberg/blob/ed8a16bbeb549b0286d3c229beb5a0cf165f2f4b/core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java#L48) [RESTSessionCatalog#L575](https://github.com/apache/iceberg/blob/ed8a16bbeb549b0286d3c229beb5a0cf165f2f4b/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L575) So indeed we need only to close the IO once per table instance, not once per writer. Thanks for catching that! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
