stankiewicz commented on code in PR #37718:
URL: https://github.com/apache/beam/pull/37718#discussion_r2918062051
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dofn/ReadChangeStreamPartitionDoFnTest.java:
##########
@@ -68,6 +68,7 @@ public class ReadChangeStreamPartitionDoFnTest {
Timestamp.ofTimeSecondsAndNanos(10, 20);
private static final Timestamp PARTITION_END_TIMESTAMP =
Timestamp.ofTimeSecondsAndNanos(30, 40);
private static final long PARTITION_HEARTBEAT_MILLIS = 30_000L;
+ private static final boolean CANCEL_QUERY_ON_HEARTBEAT = false;
Review Comment:
Doesn't change anything, as ReadChangeStreamPartitionDoFn params are mostly
passthrough and early cancellation logic is tested in
QueryChangeStreamActionTests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
