tianz101 commented on code in PR #37718:
URL: https://github.com/apache/beam/pull/37718#discussion_r2928197795
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java:
##########
@@ -2018,13 +2060,24 @@ &&
getInclusiveStartAt().toSqlTimestamp().after(getInclusiveEndAt().toSqlTimesta
MoreObjects.firstNonNull(getWatermarkRefreshRate(),
DEFAULT_WATERMARK_REFRESH_RATE);
final CacheFactory cacheFactory = new CacheFactory(daoFactory,
watermarkRefreshRate);
+ final long heartbeatMillis = getHeartbeatMillis().longValue();
+
final InitializeDoFn initializeDoFn =
- new InitializeDoFn(daoFactory, mapperFactory, startTimestamp,
endTimestamp);
+ new InitializeDoFn(
+ daoFactory, mapperFactory, startTimestamp, endTimestamp,
heartbeatMillis);
final DetectNewPartitionsDoFn detectNewPartitionsDoFn =
new DetectNewPartitionsDoFn(
daoFactory, mapperFactory, actionFactory, cacheFactory, metrics);
+ final Duration realTimeCheckpointInterval =
getRealTimeCheckpointInterval();
+
final ReadChangeStreamPartitionDoFn readChangeStreamPartitionDoFn =
- new ReadChangeStreamPartitionDoFn(daoFactory, mapperFactory,
actionFactory, metrics);
+ new ReadChangeStreamPartitionDoFn(
+ daoFactory,
+ mapperFactory,
+ actionFactory,
+ metrics,
+ realTimeCheckpointInterval,
Review Comment:
Maybe getRealTimeCheckpointInterval() here directly w/o assign to a variable
first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
