BentsiLeviav commented on code in PR #37815:
URL: https://github.com/apache/beam/pull/37815#discussion_r2971341565
##########
sdks/java/io/clickhouse/src/main/java/org/apache/beam/sdk/io/clickhouse/ClickHouseIO.java:
##########
@@ -249,16 +249,13 @@ public PDone expand(PCollection<T> input) {
tableSchema = getTableSchema(clickHouseUrl(), database(), table(),
properties());
}
- String sdkVersion = ReleaseInfo.getReleaseInfo().getSdkVersion();
- String userAgent = String.format("Apache Beam/%s", sdkVersion);
-
Properties properties = properties();
set(properties, "max_insert_block_size", maxInsertBlockSize());
set(properties, "insert_quorum", insertQuorum());
set(properties, "insert_distributed_sync", insertDistributedSync());
set(properties, "insert_deduplication", insertDeduplicate());
- set(properties, "product_name", userAgent);
+ set(properties, "client_name", buildClientName(properties));
Review Comment:
Added a section about it to the auto generated docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
