Abacn commented on code in PR #37815:
URL: https://github.com/apache/beam/pull/37815#discussion_r2995315440
##########
sdks/java/io/clickhouse/build.gradle:
##########
@@ -73,3 +73,8 @@ processTestResources {
// BEAM-12390: config.d/zookeeper_default.xml should have xx4 permission.
fileMode 0644
}
+
+test {
+ // Include integration tests (Testcontainers-based *IT classes) alongside
unit tests
+ include "**/*IT.class"
Review Comment:
`test` is for unit tests. Integration test should locates in
`integrationTest` task. To do so, add
```
provideIntegrationTestingDependencies()
enableJavaPerformanceTesting()
```
(see
https://github.com/apache/beam/blob/master/sdks/java/io/jdbc/build.gradle for
example)
then add the target to
https://github.com/apache/beam/blob/f8dbba156db35b1d16ee78ce0e76c7d725099017/.github/workflows/beam_PreCommit_Java_Clickhouse_IO_Direct.yml#L91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
