kennknowles commented on code in PR #37902:
URL: https://github.com/apache/beam/pull/37902#discussion_r2983083589
##########
runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/GroupByWithNullValuesTest.java:
##########
@@ -40,6 +40,7 @@
/** Tests grouping with null values. */
public class GroupByWithNullValuesTest implements Serializable {
+ @SuppressWarnings("VoidUsed")
Review Comment:
suppression can be more tight on the method that uses a void on purpose
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java:
##########
@@ -914,7 +914,9 @@ public void
testSideInputAnnotationFailedValidationMissing() {
DoFn<Integer, List<Integer>> fn =
new DoFn<Integer, List<Integer>>() {
@ProcessElement
- public void processElement(@SideInput(sideInputTag1) String tag1)
{}
+ public void processElement(@SideInput(sideInputTag1) String tag1) {
+ ProcessContext c;
Review Comment:
?
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java:
##########
@@ -2615,7 +2615,7 @@ public DataSource apply(Void input) {
return instances.computeIfAbsent(
config.config,
ignored -> {
- DataSource basicSource = config.apply(input);
+ DataSource basicSource = config.apply(null);
Review Comment:
I don't have context, but I assume there is some reason that it communicates
something to actually use `input` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
