stankiewicz commented on code in PR #37902:
URL: https://github.com/apache/beam/pull/37902#discussion_r2983994173
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java:
##########
@@ -2615,7 +2615,7 @@ public DataSource apply(Void input) {
return instances.computeIfAbsent(
config.config,
ignored -> {
- DataSource basicSource = config.apply(input);
+ DataSource basicSource = config.apply(null);
Review Comment:
nope, it's SerializableFunction<Void, DataSource>, it should be
SerializableSupplier<DataSource>, I will note it down and maybe refactor it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
