parveensania commented on code in PR #37840:
URL: https://github.com/apache/beam/pull/37840#discussion_r2992473787
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/stubs/IsolationChannelTest.java:
##########
@@ -49,42 +49,12 @@
import org.mockito.ArgumentCaptor;
import org.mockito.InOrder;
-/**
- * {@link NoopClientCall} is a class that is designed for use in tests. It is
designed to be used in
- * places where a scriptable call is necessary. By default, all methods are
noops, and designed to
- * be overridden.
- */
-class NoopClientCall<ReqT, RespT> extends ClientCall<ReqT, RespT> {
-
- /**
- * {@link NoopClientCall.NoopClientCallListener} is a class that is designed
for use in tests. It
- * is designed to be used in places where a scriptable call listener is
necessary. By default, all
- * methods are noops, and designed to be overridden.
- */
- public static class NoopClientCallListener<T> extends ClientCall.Listener<T>
{}
-
- @Override
- public void start(ClientCall.Listener<RespT> listener, Metadata headers) {}
-
- @Override
- public void request(int numMessages) {}
-
- @Override
- public void cancel(String message, Throwable cause) {}
-
- @Override
- public void halfClose() {}
-
- @Override
- public void sendMessage(ReqT message) {}
-}
-
@RunWith(JUnit4.class)
public class IsolationChannelTest {
private Supplier<ManagedChannel> channelSupplier = mock(Supplier.class);
- private static class NoopMarshaller implements Marshaller<Object> {
+ public static class NoopMarshaller implements Marshaller<Object> {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
