parveensania commented on code in PR #37840:
URL: https://github.com/apache/beam/pull/37840#discussion_r3018140963
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -813,25 +813,25 @@ private static ChannelCache createChannelCache(
GrpcDispatcherClient dispatcherClient) {
ChannelCache channelCache =
ChannelCache.create(
- (currentFlowControlSettings, serviceAddress) ->
- // IsolationChannel wraps FailoverChannel so that each active
RPC gets its own
- // FailoverChannel instance. FailoverChannel creates two
channels (primary,
- // fallback)
- // per active RPC.
- IsolationChannel.create(
- () ->
- FailoverChannel.create(
- remoteChannel(
- serviceAddress,
-
workerOptions.getWindmillServiceRpcChannelAliveTimeoutSec(),
- currentFlowControlSettings),
- remoteChannel(
-
dispatcherClient.getDispatcherEndpoints().iterator().next(),
-
workerOptions.getWindmillServiceRpcChannelAliveTimeoutSec(),
- currentFlowControlSettings),
- MoreCallCredentials.from(
- new
VendoredCredentialsAdapter(workerOptions.getGcpCredential()))),
- currentFlowControlSettings.getOnReadyThresholdBytes()));
+ (currentFlowControlSettings, serviceAddress) -> {
+ // IsolationChannel wrapping FailoverChannel so that each active
RPC gets its own
+ // FailoverChannel instance. FailoverChannel creates two
channels (primary,
+ // fallback) per active RPC.
+ return IsolationChannel.create(
+ () ->
+ FailoverChannel.create(
+ remoteChannel(
+ serviceAddress,
+
workerOptions.getWindmillServiceRpcChannelAliveTimeoutSec(),
+ currentFlowControlSettings),
+ remoteChannel(
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
