nikitagrover19 commented on code in PR #37345:
URL: https://github.com/apache/beam/pull/37345#discussion_r3004737738
##########
sdks/python/apache_beam/io/gcp/pubsub_integration_test.py:
##########
@@ -305,6 +305,51 @@ def test_batch_write_with_attributes(self):
"""Test WriteToPubSub in batch mode with attributes."""
self._test_batch_write(with_attributes=True)
+ @pytest.mark.it_postcommit
Review Comment:
Correct - the `_flush` fix in `_PubSubWriteDoFn` only applies to Direct
Runner since Dataflow overrides this with its own implementation. Will add a
comment to the integration test clarifying this scope. For the warning - I'll
add a `logging.warning` in `_PubSubWriteDoFn` when `ordering_key` is set on any
message, advising Dataflow users to use the WriteToPubSub XLang path instead.
Does that approach sound right, or would you prefer it at pipeline construction
time (e.g., in `WriteToPubSub.expand()`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
