tvalentyn commented on code in PR #37345:
URL: https://github.com/apache/beam/pull/37345#discussion_r3023958632
##########
sdks/python/apache_beam/io/gcp/pubsub_integration_test.py:
##########
@@ -305,6 +305,62 @@ def test_batch_write_with_attributes(self):
"""Test WriteToPubSub in batch mode with attributes."""
self._test_batch_write(with_attributes=True)
+ @pytest.mark.it_postcommit
+ def test_batch_write_with_ordering_key(self):
+ """Test WriteToPubSub in batch mode with ordering keys.
+ This test only applies to the Direct Runner. The ordering key fix in
Review Comment:
> The ordering key fix in _PubSubWriteDoFn._flush() does not apply to
Dataflow,
Wording suggestion: I'd avoid low-level details and say smth like:
Dataflow Native Pubsub Sink doesn't support ordering_key: <link with
details/open issue>, therefore this test only applies to runners that use
Beam's Python WriteToPubSub Sink.
To use ordering_key, Dataflow users should use the XLang WriteToPubSub path
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
