tvalentyn commented on code in PR #37989:
URL: https://github.com/apache/beam/pull/37989#discussion_r3029597734
##########
sdks/python/apache_beam/yaml/yaml_provider.py:
##########
@@ -1412,7 +1412,8 @@ def _create_venv_from_clone(
@classmethod
def _create_venv_to_clone(cls, base_python: str) -> str:
- if '.dev' in beam_version:
+ _ci = os.environ.get('CI', '').lower() in ('true', '1', 'yes')
Review Comment:
can we add rationale here for this change? It would be better to make this
change in a separate PR and clarify context + rationale in the description in
addition to small the comment here.
##########
sdks/python/apache_beam/yaml/yaml_provider.py:
##########
@@ -1412,7 +1412,8 @@ def _create_venv_from_clone(
@classmethod
def _create_venv_to_clone(cls, base_python: str) -> str:
- if '.dev' in beam_version:
+ _ci = os.environ.get('CI', '').lower() in ('true', '1', 'yes')
Review Comment:
can we add rationale here for this change? Also, it would be better to make
this change in a separate PR and clarify context + rationale in the description
in addition to small the comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
