tvalentyn commented on code in PR #37989:
URL: https://github.com/apache/beam/pull/37989#discussion_r3029607014
##########
sdks/python/apache_beam/yaml/yaml_provider.py:
##########
@@ -1412,7 +1412,8 @@ def _create_venv_from_clone(
@classmethod
def _create_venv_to_clone(cls, base_python: str) -> str:
- if '.dev' in beam_version:
+ _ci = os.environ.get('CI', '').lower() in ('true', '1', 'yes')
Review Comment:
> if '.dev' in beam_version and not _ci:
I wonder if the `if '.dev'` specifically targeted the CI. In this case
removing the whole branch makes more sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
