Eliaaazzz opened a new pull request, #38145:
URL: https://github.com/apache/beam/pull/38145
Consolidate the two duplicate `ShardedKey` classes in the Java SDK core
module into a single unified implementation, addressing the confusion and error
risk caused by having overlapping classes with different shard ID types.
**What changed:**
- Removed the deprecated `org.apache.beam.sdk.values.ShardedKey` (int-based
shard) and its companion `org.apache.beam.sdk.coders.ShardedKeyCoder`
- Added `of(K, int)` factory method and `getShardNumber()` accessor to
`org.apache.beam.sdk.util.ShardedKey` so callers using integer shard numbers
migrate without logic changes
- Migrated all consumers across core SDK (WriteFiles, ShardingFunction),
BigQuery IO (BatchLoads, WriteTables, WritePartition, WriteBundlesToFiles,
StreamingWriteTables, GenerateShardedTable), Flink runner, and Spark runner
- Simplified auto-sharded write paths in WriteFiles and BatchLoads that
previously had awkward conversion code between the two ShardedKey types
- Added tests for the new int-based shard methods and coder round-trip
behavior
Fixes #37990
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
