gemini-code-assist[bot] commented on PR #38194: URL: https://github.com/apache/beam/pull/38194#issuecomment-4246116086
## Summary of Changes Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Java SDK's schema inference capabilities by introducing native support for modern Java date/time types (JSR-310) and UUIDs as Beam logical types. This change streamlines the process of converting Java objects (POJOs and JavaBeans) containing these types into Beam Rows and vice-versa, improving data interoperability and addressing a known issue related to schema assignability with external systems like Iceberg. ### Highlights * **JSR-310 and UUID Logical Type Inference**: The `StaticSchemaInference.fieldFromType()` method now correctly maps `java.time.LocalDate`, `LocalTime`, `LocalDateTime`, `java.time.Instant`, and `UUID` to their corresponding Beam logical types (`SqlTypes.DATE`, `TIME`, `DATETIME`, `NanosInstant`, `SqlTypes.UUID`). * **ByteBuddyUtils Enhancements for JSR-310/UUID Conversions**: `ByteBuddyUtils` has been updated to include `convertJavaTimeLogicalType()` in both getter and setter codegen paths. This ensures that POJO/Bean to Row and Row to POJO/Bean round-trips work correctly for these new logical types by calling `LogicalType.toBaseType()` and `toInputType()` respectively. * **Comprehensive Test Coverage**: Extensive tests have been added to cover schema inference, `toRow` and `fromRow` conversions, round-trip functionality, nullable fields, mixed schemas, and backward compatibility with Joda `ReadableInstant` to prevent regressions. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
