aIbrahiim commented on PR #38237: URL: https://github.com/apache/beam/pull/38237#issuecomment-4271019421
> I don't see it's being setup for cloud etc > > https://github.com/apache/beam/blob/4e24a9c69f1764e010f2489c4815ccf821e744ac/.github/workflows/beam_PreCommit_Python_Examples.yml#L97 > > Do you mean TestPipelines.pytest_test_pipeline_options could get mutated by one test and affecting other tests? Nor this is immutable as it's a str yeah that YAML line doesnt pass cloud runner flags and the “cloud” bit is indirect as preCommitPy… runs both the normal tox env and the py*-cloud one (wired up in the tox Gradle common.gradle), so its not obvious from the workflow file alone and yeah, not saying the string gets mutated between tests. pytest_test_pipeline_options is basically “whatever pytest got for --test-pipeline-options at session start.” so my change is just about not using that global fallback for regular unit-style TestPipeline unless it’s actually an integration test (is_integration_test) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
