aIbrahiim commented on PR #38237: URL: https://github.com/apache/beam/pull/38237#issuecomment-4271346781
> After checking logs / code I don't think this is relevant > > The PreCommit runs four independent pytest command, initiated from run_pytest.sh > > ``` > Running parallel tests with: pytest -m "not no_xdist" --pyargs apache_beam/examples/ > Running sequential tests with: pytest -m "no_xdist" --pyargs apache_beam/examples/ > Running parallel tests with: pytest -m "not no_xdist" --pyargs apache_beam/examples/ > Running sequential tests with: pytest -m "no_xdist" --pyargs apache_beam/examples/ > ``` > > There are duplicate commands because one without extensions (from normal tox target), one with cloud dependency extensions (from *-cloud tox target). TestPipelines.pytest_test_pipeline_options stays empty all time. > > I don't think we want to change the behavior of flag here. It may break internal / downstream tests Yeah thanks and makes sense as my as I did investigation in assuming global options were leaking and logs you showed say they’re not in this precommit path, so I agree the TestPipeline change isnt the right fix here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
