pabloem commented on a change in pull request #12782:
URL: https://github.com/apache/beam/pull/12782#discussion_r493916902
##########
File path: sdks/python/apache_beam/io/gcp/big_query_query_to_table_pipeline.py
##########
@@ -91,24 +91,16 @@ def run_bq_pipeline(argv=None):
use_standard_sql=known_args.use_standard_sql,
use_json_exports=known_args.use_json_exports,
kms_key=kms_key)
- if known_args.native:
- _ = data | 'write' >> beam.io.Write(
- beam.io.BigQuerySink(
- known_args.output,
- schema=table_schema,
- create_disposition=beam.io.BigQueryDisposition.CREATE_IF_NEEDED,
- write_disposition=beam.io.BigQueryDisposition.WRITE_EMPTY,
- kms_key=kms_key))
- else:
- temp_file_format = (
- 'NEWLINE_DELIMITED_JSON' if known_args.use_json_exports else 'AVRO')
- _ = data | 'write' >> beam.io.WriteToBigQuery(
- known_args.output,
- schema=table_schema,
- create_disposition=beam.io.BigQueryDisposition.CREATE_IF_NEEDED,
- write_disposition=beam.io.BigQueryDisposition.WRITE_EMPTY,
- temp_file_format=temp_file_format,
- kms_key=kms_key)
+
+ temp_file_format = (
Review comment:
this does not update the sink, but the sink has been deprecated for a
while. I just removed this from the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
