pabloem commented on a change in pull request #12782:
URL: https://github.com/apache/beam/pull/12782#discussion_r493919995
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner_test.py
##########
@@ -269,7 +260,9 @@ def test_biqquery_read_fn_api_fail(self):
'apache_beam.io.gcp.bigquery.ReadFromBigQuery.*'):
with Pipeline(remote_runner,
PipelineOptions(self.default_properties)) as p:
- _ = p | beam.io.Read(beam.io.BigQuerySource('some.table'))
+ _ = p | beam.io.Read(
+ beam.io.BigQuerySource(
Review comment:
discussing this in the next comment.
##########
File path: sdks/python/apache_beam/io/iobase.py
##########
@@ -890,6 +890,8 @@ def get_desired_chunk_size(total_size):
def expand(self, pbegin):
if isinstance(self.source, BoundedSource):
return pbegin | _SDFBoundedSourceWrapper(self.source)
+ elif isinstance(self.source, ptransform.PTransform):
+ return pbegin.pipeline | self.source
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
