tkaymak commented on PR #38255: URL: https://github.com/apache/beam/pull/38255#issuecomment-4289721759
**End-to-end smoke test (Spark 4.0.2 / Scala 2.13 / Java 17):** Built `:runners:spark:4` from `6eea847f5b`, pulled it into `:examples:java`'s runtime classpath, and ran `WordCount`. Pipeline completed cleanly (`Batch pipeline execution complete.`) and the word counts are correct. A few items worth flagging before merge: 1. **Gemini round 4 nit not yet addressed** — `runners/spark/4/src/main/java/.../batch/GroupByKeyHelpers.java:83` has a redundant unchecked cast `(Collection<BoundedWindow>) v.getWindows()`. The identical line is also in the shared base at `runners/spark/src/main/java/.../batch/GroupByKeyHelpers.java:83` — per the round-2 pattern, fix in both. 2. **SLF4J↔JUL loop in mixed classpaths**: Spark 4 brings `jul-to-slf4j`; if the consuming module also pulls `slf4j-jdk14` you get a `StackOverflowError` on the first log line. Worth a runner README note (or a runtime exclusion in the module). 3. Friendly reminder of the still-owed `flink_runner.gradle` follow-up PR for the version-comparison fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
