tkaymak commented on PR #38255: URL: https://github.com/apache/beam/pull/38255#issuecomment-4294731995
Two follow-ups pushed (`ecd260f5`, `d6116e28`): 1. **Gemini round 4 nit addressed** — `GroupByKeyHelpers.java:83` no longer has the redundant unchecked `Collection<BoundedWindow>` cast; passing `v.getWindows()` directly to `ScalaInterop.scalaIterator(...)` compiles cleanly. Fix applied in both the Spark 4 override and the shared base. 2. **`runners/spark/4/README.md` added** — covers requirements (Java 17, Scala 2.13, Spark 4.0.x, batch-only) and a "Known issues" section documenting the `slf4j-jdk14` ↔ `jul-to-slf4j` `StackOverflowError`, with a pointer to #26985 / #27001 (the Spark 3 precedent) and the workaround for downstream Gradle/Maven consumers. The shared `spark_runner.gradle` already excludes `slf4j-jdk14` for in-tree builds, so this is purely consumer-facing documentation — matching @Abacn's "follow up on documentation or exclude dependencies" suggestion. Branch: `tkaymak:spark4-runner-slim` @ `d6116e28`. PTAL when you get a chance, @Abacn. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
