parveensania commented on code in PR #38249:
URL: https://github.com/apache/beam/pull/38249#discussion_r3121411238
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/streaming/harness/FanOutStreamingEngineWorkerHarnessTest.java:
##########
@@ -348,6 +348,48 @@ public void testOnNewWorkerMetadata_redistributesBudget()
throws InterruptedExce
TimeUnit.SECONDS.sleep(WAIT_FOR_METADATA_INJECTIONS_SECONDS);
}
+ @Test
+ public void
testOnNewWorkerMetadata_consumesEndpointsOnConnectivityTypeChange()
+ throws InterruptedException {
+ String workerToken = "workerToken1";
+
+ WorkerMetadataResponse firstWorkerMetadata =
+ WorkerMetadataResponse.newBuilder()
+ .setMetadataVersion(1)
+
.setEndpointType(Windmill.WorkerMetadataResponse.EndpointType.CLOUDPATH)
+ .addWorkEndpoints(
+ WorkerMetadataResponse.Endpoint.newBuilder()
+ .setBackendWorkerToken(workerToken)
+ .build())
+ .putAllGlobalDataEndpoints(DEFAULT)
+ .build();
+ WorkerMetadataResponse secondWorkerMetadata =
+ WorkerMetadataResponse.newBuilder()
+ .setMetadataVersion(1)
+
.setEndpointType(Windmill.WorkerMetadataResponse.EndpointType.DIRECTPATH)
+ .addWorkEndpoints(
+ WorkerMetadataResponse.Endpoint.newBuilder()
+ .setBackendWorkerToken(workerToken)
+ .build())
+ .putAllGlobalDataEndpoints(DEFAULT)
+ .build();
+
+ TestGetWorkBudgetDistributor getWorkBudgetDistributor = spy(new
TestGetWorkBudgetDistributor());
+ fanOutStreamingEngineWorkProvider =
+ newFanOutStreamingEngineWorkerHarness(
+ GetWorkBudget.builder().setItems(1).setBytes(1).build(),
+ getWorkBudgetDistributor,
+ noOpProcessWorkItemFn());
+
+ fakeGetWorkerMetadataStub.injectWorkerMetadata(firstWorkerMetadata);
Review Comment:
added additional checks in testcase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
