parveensania commented on code in PR #38249:
URL: https://github.com/apache/beam/pull/38249#discussion_r3128040623
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/harness/FanOutStreamingEngineWorkerHarness.java:
##########
@@ -271,8 +279,14 @@ private void consumeWorkerMetadata(WindmillEndpoints
windmillEndpoints) {
synchronized (metadataLock) {
// Only process versions greater than what we currently have to prevent
double processing of
// metadata. workerMetadataConsumer is single-threaded so we maintain
ordering.
- if (windmillEndpoints.version() > pendingMetadataVersion) {
+ // The endpoints are also consumed if the version is the same but the
type of endpoints
+ // sent by the server has changed.
+ if (windmillEndpoints.version() > pendingMetadataVersion
+ || (windmillEndpoints.version() == pendingMetadataVersion
Review Comment:
Done. Considering we only expect monotonically increasing version, we can
remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
