shunping commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3169518479
##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger
*tools.Logger, files []str
bufLogger := tools.NewBufferedLogger(logger)
bufLogger.Printf(ctx, "Installing setup packages ...")
+ if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation");
err != nil {
Review Comment:
We called the same function after installation. However if any of the
installation steps fail, boot.go will exit the process before reaching this
function.
That's why I want to call the same function before installation. This
ensures we have that we will be able to see the information no matter the
installation is successful or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
