shunping commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3169833986
##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger
*tools.Logger, files []str
bufLogger := tools.NewBufferedLogger(logger)
bufLogger.Printf(ctx, "Installing setup packages ...")
+ if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation");
err != nil {
Review Comment:
The new logs only add 4 lines and are already emitted at the DEBUG level,
which allows users to filter them out as needed.
Given this minimal footprint, I’d prefer to avoid adding complexity of a new
configuration mechanism or flag in `boot.go` to keep the boot logic as simple
as possible.
<img width="2058" height="494" alt="image"
src="https://github.com/user-attachments/assets/ea5b8041-cc60-4d4c-99f0-e9d462d4337e";
/>
> 'pre-installation', 'post-installation' sounds a bit cryptic for end user
who is not a beam dev.
I used the term "installation" because of the line of "Installing setup
packages ..." prior to these logs (see above screenshot too), but I am open to
any better term.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
