tkaymak commented on PR #38255: URL: https://github.com/apache/beam/pull/38255#issuecomment-4387703960
Hi @Abacn — Phase 1 #38324 is in and this branch is now rebased on master at `2bf36073ec` (net 2952 / 26 across 34 files). Before I start carving, I'd like your view on splitting the remainder into 3 stacked PRs, ordered by **blast radius** rather than file area: **1. Shared-base Scala 2.12/2.13 compat tweaks + codecov tests** (~240 lines) The small `runners/spark/src/` prod-side tweaks (null-guard in `EvaluationContext`, Scala-array fallback in `SparkRunnerKryoRegistrator`, the terminology / `.cancel()` / Scala-2.13 cast nits) plus the two new tests `EvaluationContextTest` and `SparkRunnerKryoRegistratorTest`. Only chunk touching code Spark 3 users run today — gated by the existing Spark 3 PreCommit, isolated reviewer attention, no new-module surface. **2. Spark 4 CI workflows** (~217 lines) The two `beam_*Spark4*` YAMLs + trigger JSONs + `.github/workflows/README.md` entry. Lands before the module on purpose: silent YAML bugs (`paths:` / `on:` typos) surface on PR 3's first run; I can also force a `workflow_dispatch` smoke on the branch before merge. **3. Spark 4 runner module + wiring** (~2480 lines) Entire `runners/spark/4/` tree (11 Java overrides + `EncoderHelpersTest` + `build.gradle` / `README` / job-server / Dockerfile) plus `settings.gradle.kts` (+3) and `gradle.properties` flip to `spark_versions=3,4`. I'll drop the `CHANGES.md` entry and defer to Highlights as you suggested for Phase 1. Big diff but additive and isolated — gated by PR 2's workflows, no Spark 3 consumer. Happy to ship in this order, or bundle CI back into the module PR if you'd rather one fewer round-trip. Let me know what fits your queue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
