Abacn commented on code in PR #38255: URL: https://github.com/apache/beam/pull/38255#discussion_r3203194784
########## runners/spark/4/job-server/container/build.gradle: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +def basePath = '../../../job-server/container' + +project.ext { + resource_path = basePath + spark_job_server_image = 'spark4_job_server' +} + +// Load the main build script which contains all build logic. +apply from: "$basePath/spark_job_server_container.gradle" + +// Override the Dockerfile copy to use the Java 17 Dockerfile for Spark 4. +copyDockerfileDependencies { + // Remove the shared Dockerfile added by the shared gradle script and use the local one instead. + // The shared Dockerfile uses eclipse-temurin:11 which is incompatible with Spark 4 (requires Java 17). + exclude 'Dockerfile' +} + +task copySpark4Dockerfile(type: Copy) { Review Comment: Execution failed for task ':runners:spark:4:job-server:container:dockerPrepare'. > Entry Dockerfile is a duplicate but no duplicate handling strategy has been set. Please refer to https://docs.gradle.org/8.14.3/dsl/org.gradle.api.tasks.Copy.html#org.gradle.api.tasks.Copy:duplicatesStrategy for details. Needs some logic to handle dockerfile file pickup here. I can defer the runners/spark/job-server/container module to portable runner support later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
