damccorm commented on code in PR #38215: URL: https://github.com/apache/beam/pull/38215#discussion_r3219867060
########## sdks/python/apache_beam/testing/benchmarks/inference/mltransform_generate_vocab_benchmark.py: ########## @@ -0,0 +1,56 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""Benchmark test for the batch-only MLTransform Generate Vocab pipeline.""" + +import logging + +from apache_beam.examples.ml_transform import mltransform_generate_vocab +from apache_beam.testing.load_tests.dataflow_cost_benchmark import DataflowCostBenchmark + + +class MLTransformGenerateVocabBenchmarkTest(DataflowCostBenchmark): + """Runs the MLTransform vocab generation pipeline as a cost benchmark.""" + def __init__(self): + # Namespace used by benchmark dashboards. + self.metrics_namespace = 'BeamML_MLTransformVocab' + # Monitor token throughput after filtering empty values. + super().__init__( + metrics_namespace=self.metrics_namespace, + is_streaming=False, + pcollection='DropEmptyTokens.out0') Review Comment: Please fix this - otherwise, LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
