tkaymak commented on code in PR #38453:
URL: https://github.com/apache/beam/pull/38453#discussion_r3225387922
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -1516,72 +1516,66 @@ class BeamModulePlugin implements Plugin<Project> {
project.tasks.analyzeDependencies.enabled = false
}
- // errorprone requires java9+ compiler. It can be used with Java8 but
then sets a java9+ errorproneJavac.
- // However, the redirect ignores any task that forks and defines either
a javaHome or an executable,
- // see https://github.com/tbroyer/gradle-errorprone-plugin#jdk-8-support
- // which means errorprone cannot run when gradle runs on Java11+ but
serve `-testJavaVersion=8 -Pjava8Home` options
- if (!(project.findProperty('testJavaVersion') == '8')) {
- // Enable errorprone static analysis
- project.apply plugin: 'net.ltgt.errorprone'
+ // Enable errorprone static analysis
Review Comment:
Nit: removing the dead Java-8 gate around the errorprone block is a fine
cleanup (Java 8 isn't in the supported `testJavaVersion` set
`['11','17','21','25']` anymore), but it's unrelated to the Spark 4 test wiring
this PR is otherwise about, and it accounts for most of the diff's visual size.
Happy to approve as-is - just a one-line mention in the description would help
in the future maybe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
