Abacn commented on code in PR #38453:
URL: https://github.com/apache/beam/pull/38453#discussion_r3227277811
##########
.github/workflows/beam_PreCommit_Java_Spark_Versions.yml:
##########
@@ -15,21 +15,21 @@
# specific language governing permissions and limitations
# under the License.
-name: PreCommit Java Spark3 Versions
+name: PreCommit Java Spark Versions
on:
push:
tags: ['v*']
branches: ['master', 'release-*']
paths:
- 'runners/spark/**'
- - '.github/workflows/beam_PreCommit_Java_Spark3_Versions.yml'
+ - '.github/workflows/beam_PreCommit_Java_Spark_Versions.yml'
pull_request_target:
branches: ['master', 'release-*']
paths:
- 'runners/spark/**'
- 'release/trigger_all_tests.json'
- - '.github/trigger_files/beam_PreCommit_Java_Spark3_Versions.json'
+ - '.github/trigger_files/beam_PreCommit_Java_Spark_Versions.json'
Review Comment:
I've seen a few occurrences AI-assisted PRs keep adding trigger file json
for new workflow addition, which is not necessary. Creation or modification of
trigger file is only needed when the PR author want to trigger a specific
PostCommit manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
